Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Puppet v4 #51

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Support Puppet v4 #51

wants to merge 3 commits into from

Conversation

ghoneycutt
Copy link

Modernize module

  • Drop support for Puppet v2.

  • Add support for Puppet v4.

  • Explicitly test against supported Ruby and Puppet matrix.

  • Support Ruby versions 1.8.7, 1.9.3, 2.0.0, 2.1.0 and 2.3.1.

  • Use puppet-lint v2.

  • Use community puppet-lint plugins (Code already complied with the
    style).

Modernize module

* Drop support for Puppet v2.

* Add support for Puppet v4.

* Explicitly test against supported Ruby and Puppet matrix.

* Support Ruby versions 1.8.7, 1.9.3, 2.0.0, 2.1.0 and 2.3.1.

* Use puppet-lint v2.

* Use community puppet-lint plugins (Code already complied with the
  style).
@ghoneycutt
Copy link
Author

Hi @thias could you please merge this

@snahelou
Copy link

Hello

Great job, I need this feature too :)

Regards

@Phil-Friderici
Copy link

Phil-Friderici commented Feb 28, 2017

Hej @thias,
We are using a setup like @ghoneycutt proposed since years and it helps us a lot.
It will create tests in all combinations of Puppet & Ruby, here is an example: https://travis-ci.org/Phil-Friderici/puppet-module-afs/builds/203724249

Please give it a try :)

@Phil-Friderici
Copy link

If you are interessted in this, I can add the needed changes to keep this running with the latest Puppets and gem versions.

@ghoneycutt
Copy link
Author

@Phil-Friderici I would be happy to accept those in my branch if you would like to submit a PR against that.

@Phil-Friderici
Copy link

@ghoneycutt sent a PR to your branch

@thias my repo has Travis CI enabled and you can have a peek how a PR will looks like with it [1] and what nice overview you get about the tested combinations of Puppet and Ruby [2].

[1] Phil-Friderici#1
[2] https://travis-ci.org/Phil-Friderici/puppet-sysctl/builds/221247268

Update testing rig for Puppet 4.10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants